fix(miners): use API successMultiplier in score composite footer#116
Open
Yurii214 wants to merge 1 commit into
Open
fix(miners): use API successMultiplier in score composite footer#116Yurii214 wants to merge 1 commit into
Yurii214 wants to merge 1 commit into
Conversation
Stop recomputing (successRate30d × credibilityRamp)³ client-side; the score-factors endpoint already returns the canonical successMultiplier. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
Why this is safe
@anderdc @LandynDev — ready for review when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
successMultiplierwhen composing the miner score-factors footer total instead of recomputing(successRate30d × credibilityRamp)³client-side.success=successMultiplierfrom/score-factors).Problem
ScoreFactorsStripfooter ("share of pool captured this round") multiplied crown, capacity, and volume factors against a client-derived(successRate30d × credibilityRamp)³term.The
/miners/:hotkey/score-factorsresponse already includessuccessMultiplier(the canonical success term computed server-side), but the UI never used it. This left the footer value vulnerable to drift from backend scoring logic and contradicted the stale inline formula note.Changes
src/components/miners/ScoreFactorsStrip.tsxcomposeMultiplier:sf.successMultiplierreplaces(sf.successRate30d * sf.credibilityRamp) ** 3= crown × cap × vol × successWhy this is safe
Test plan
npm run lintnpm run build/miners/:hotkey: footer value trackscrownShareWindow × capacityFactor × volumeFactor × successMultiplier(rounded display)Made with Cursor