fix(watchlist): normalize and dedupe persisted ids#1301
Closed
jony376 wants to merge 2 commits into
Closed
Conversation
Collaborator
|
The add/toggle paths already block duplicates via the existing includes() guard, and every watchlist id comes from structured API data — repo full names, hotkeys, serialized PR keys — that carries no whitespace. The duplicate/whitespace state this normalizes is only reachable by hand-editing localStorage, which is exactly the reproduction in #1300. No real-world path produces the drift. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize and dedupe persisted watchlist IDs across all categories to prevent inflated badge counts and inconsistent watched-state behavior.
Changes
trim + dedupe + empty removal) in watchlist storage read path.Related Issues
Closes #1300
Type of Change
Testing
npm run buildpassesNot run locally in this pass.
Checklist