Conversation
Add tests exercising API patterns that OTP depends on, covering types not previously tested: Network, DestinationDisplay, ScheduledStopPoint, ServiceLink, FlexibleLine, GroupOfLines, Notice, NoticeAssignment, AccessibilityAssessment, FlexibleStopPlace, Parking, ServiceJourneyInterchange, FlexibleServiceProperties (booking), Branding, and Authority/Operator contact details. These tests use MultilingualString.getValue(), AllVehicleModesOfTransport Enumeration, collection accessors like getLine_() and getOrganisation_(), and ObjectFactory builder methods that will break in NeTEx 2.0, ensuring we can verify all use cases are properly migrated.
Add tests exercising API patterns that Chouette depends on, covering types not previously tested: - BookingArrangementsStructure on StopPointInJourneyPattern: bookingNote .getValue(), bookingAccess, bookWhen, buyWhen (@xmllist), bookingMethods, latestBookingTime, minimumBookingPeriod, bookingContact - DeadRun: getName().getValue(), getDayTypes(), getJourneyPatternRef(), getPassingTimes() - Block in VehicleScheduleFrame: getName/Description/PrivateCode .getValue(), startTime, endTime, startPointRef, endPointRef, dayTypes, journeys with DeadRunRefStructure and VehicleJourneyRefStructure instanceof checks - PointProjection on RoutePoint: getProjections(), getProjectToPointRef() - LinkSequenceProjection on ServiceLink: getProjections(), getLineString() - AlternativeText on Notice: getText().getValue(), getText().getLang() - DestinationDisplay Vias: getVias().getVia(), getDestinationDisplayRef() - Direction: getDirectionType() (DirectionTypeEnumeration) - Route: getDirectionType(), getDirectionRef(), getInverseRouteRef() - PresentationStructure: getColour(), getTextColour() - PrivateCodeStructure: getPrivateCode().getValue() - Codespace: getXmlns(), getXmlnsUrl() - FlexibleServiceProperties extended: getFlexibleServiceType(), isCancellationPossible(), isChangeOfTimePossible(), getBuyWhen(), getBookingNote().getValue() - TimingPointStatusEnumeration on ScheduledStopPoint - StopPlace: getDescription().getValue(), getLandmark().getValue() - Block round-trip in MarshalUnmarshalTest
…2.0 upgrade Add tests exercising API patterns that netex-validator-java depends on, covering transport submode handling not previously tested: - StopPlace with submode enums: getBusSubmode(), getRailSubmode(), getWaterSubmode(), getTramSubmode(), getMetroSubmode(), getCoachSubmode(), getFunicularSubmode(), getTelecabinSubmode(), getAirSubmode() and their .value() calls - ServiceJourney with TransportSubmodeStructure: getTransportSubmode() returning TransportSubmodeStructure, then accessing specific submode enum via getBusSubmode(), getRailSubmode(), getWaterSubmode() - Route.getLineRef().getValue().getRef() - JAXBElement-wrapped LineRef - AllVehicleModesOfTransportEnumeration values: COACH, FUNICULAR, CABLEWAY, AIR (in addition to previously tested BUS, RAIL, WATER)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.