feat: Support for merged EnvoyProxy settings#8169
Open
mgs255 wants to merge 2 commits intoenvoyproxy:mainfrom
Open
feat: Support for merged EnvoyProxy settings#8169mgs255 wants to merge 2 commits intoenvoyproxy:mainfrom
mgs255 wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8169 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 241 242 +1
Lines 36608 36675 +67
=======================================
+ Hits 27021 27073 +52
- Misses 7681 7691 +10
- Partials 1906 1911 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgs255
force-pushed
the
envoy-proxy-defaults-add-merge
branch
6 times, most recently
from
beba8a7 to
f7941fb
Compare
mgs255
changed the title
mgs255
force-pushed
the
envoy-proxy-defaults-add-merge
branch
from
f7941fb to
d2d5054
Compare
This commit is a continuation of the previous work to support supplying default proxy settings on the top level EnvoyGatewaySpec. It also introduces a the existing `MergeType` option on the `EnvoyProxySpec`. With this change it is now possible to define default proxy settings as part of the envoy-gateway configuration, and have those settings overridden by GatewayClass or Gateway referenced EnvoyProxy instances. Note that the default behavior will be that more specific proxy settings will replace those defaults. MergeType Options: - `Replace` (default) - More specific config completely replaces less specific config - `StrategicMerge` - Kubernetes-style strategic merge patch - `JSONMerge` - RFC 7396 JSON merge patch Priority Order (highest to lowest): 1. Gateway-level EnvoyProxy (via `parametersRef`) 2. GatewayClass-level EnvoyProxy 3. Default EnvoyProxySpec from EnvoyGateway configuration Towards: envoyproxy#4764 Signed-off-by: Michael Sommerville <[email protected]>
mgs255
force-pushed
the
envoy-proxy-defaults-add-merge
branch
2 times, most recently
from
2fe2d68 to
a990589
Compare
mgs255
force-pushed
the
envoy-proxy-defaults-add-merge
branch
from
a990589 to
ddaf648
Compare
Signed-off-by: Michael Sommerville <[email protected]>
mgs255
force-pushed
the
envoy-proxy-defaults-add-merge
branch
from
ddaf648 to
3126bb4
Compare
Contributor
Author
|
After a bit of a faf these failing tests with Kubebuilder setup on Mac these coverage-tests pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a continuation of the previous work to support supplying default proxy settings on the top level EnvoyGatewaySpec. It also introduces the existing
MergeTypeoption on theEnvoyProxySpecWith this change it is now possible to define default proxy settings as part of the envoy-gateway configuration, and have those settings overridden by GatewayClass or Gateway referenced EnvoyProxy instances. Note that the default behavior will be that more specific proxy settings will replace those defaults.
MergeType Options:
Replace(default) - More specific config completely replaces less specific configStrategicMerge- Kubernetes-style strategic merge patchJSONMerge- RFC 7396 JSON merge patchPriority Order (highest to lowest):
parametersRef)Release Notes: Yes
Towards: #4764