-
Notifications
You must be signed in to change notification settings - Fork 670
feat: Implement RoutingType BTP #8173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8173 +/- ##
==========================================
+ Coverage 73.81% 73.92% +0.10%
==========================================
Files 241 241
Lines 36608 36682 +74
==========================================
+ Hits 27023 27116 +93
+ Misses 7679 7661 -18
+ Partials 1906 1905 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
Signed-off-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
|
/retest |
|
/retest |
| refName := string(ref.Name) | ||
| refKind := string(ref.Kind) | ||
|
|
||
| // Check if BTP targets the route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if section name is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed section name targeting along with some others I missed like label selectors
Signed-off-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
|
/retest |
What this PR does / why we need it:
Adds implementation for BTP-level RoutingType field
Which issue(s) this PR fixes:
Fixes #7926
Release Notes: Yes