Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Feb 4, 2026

What this PR does / why we need it:
Adds implementation for BTP-level RoutingType field

Which issue(s) this PR fixes:

Fixes #7926

Release Notes: Yes

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 8d1e9e6
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/698b4d81b76abb000869699d

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 98.97959% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.92%. Comparing base (14062fa) to head (8d1e9e6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/ext_service.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8173      +/-   ##
==========================================
+ Coverage   73.81%   73.92%   +0.10%     
==========================================
  Files         241      241              
  Lines       36608    36682      +74     
==========================================
+ Hits        27023    27116      +93     
+ Misses       7679     7661      -18     
+ Partials     1906     1905       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie marked this pull request as ready for review February 4, 2026 02:55
@jukie jukie requested a review from a team as a code owner February 4, 2026 02:55
@jukie jukie changed the title Implement RoutingType BTP feat: Implement RoutingType BTP Feb 4, 2026
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
Copy link
Contributor Author

jukie commented Feb 4, 2026

/retest

@jukie jukie requested review from a team and nareddyt February 4, 2026 04:06
Signed-off-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
@jukie
Copy link
Contributor Author

jukie commented Feb 6, 2026

/retest

@jukie
Copy link
Contributor Author

jukie commented Feb 7, 2026

/retest

refName := string(ref.Name)
refKind := string(ref.Kind)

// Check if BTP targets the route
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if section name is set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed section name targeting along with some others I missed like label selectors

jukie and others added 2 commits February 8, 2026 13:54
Signed-off-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
Copy link
Contributor Author

jukie commented Feb 8, 2026

/retest

@jukie jukie requested review from a team and arkodg February 9, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting RoutingType on a per-route level

2 participants