update proto to support metadata#1174
Merged
Merged
Conversation
Signed-off-by: achoo30 <achoo30@bloomberg.net>
10 tasks
Contributor
Author
|
@agrawroh could you please review this rls change PR when you have the chance! cc @yanavlasov |
agrawroh
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata is already defined in https://github.com/envoyproxy/ratelimit/blob/main/src/config/config.go#L33. I want to expose it on the proto.
This is PR 1 of 3.
Putting a subsequent PR (as step 2) in go-control-plane to update the rls_config.pb.go similar to this PR. -- edit: This is PR 2 of 3.
As step 3, a PR similar to this will be added to reference the go-control-plane new metadata field in
src/config/config_xds.go