Repository navigation
Stop pending MCP checks from telling hosts to check again - #363
Merged
Merged
Conversation
A pending or escalated sanction_check_authorization result now tells the host the request is still awaiting the owner, not to check again. The four authorize tools keep the wait-then-check-once path. Co-authored-by: ELo <ericlovold@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ericlovold
marked this pull request as ready for review
October 8, 2026 21:29
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f78ce130-ed98-48e0-90cb-07c55bde997d) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pending
sanction_check_authorizationresults could still tell a host to call the check tool once more. A host that obeys every response literally could therefore poll forever, which broke the bounded wait path from #362.What changed for MCP hosts
sanction_check_authorizationonce withrequest_id.sanction_check_authorizationitself returns pending/escalated, structuredremediationand readable text now say the request is still awaiting the owner's decision. Do not proceed. Do not check again automatically or request another approval. Tell the owner it is awaiting approval (request_id stays visible). Check again only after they say they have decided.next_actionstayswait— the request is still open;stopwould look terminal.request_idand malformed/stop branches are unchanged. Authorization and grant semantics are unchanged.Closes the two CodeRabbit findings left on #362. Stdio bundle rebuilt; npm publication remains a separate step.
Validation:
npm run checkpassed (1,857 tests passed, 56 DB tests skipped; TypeScript and ESLint passed).git diff --checkpassed. Contract tests cover pending/escalated check results (no re-check instruction, JSON/text parity) and authorize-tool pending (still check once).