Open
Conversation
Added status badges Added information for running tests Removed info for running tests from GUI Section
s-laugh
requested changes
Mar 14, 2019
Member
s-laugh
left a comment
s-laugh
left a comment
There was a problem hiding this comment.
The order of the main sections doesn't seem logical. Tests, then running everything in docker, then specially the GUI, and nothing specific for the API.
s-laugh
reviewed
Mar 14, 2019
s-laugh
reviewed
Mar 15, 2019
| Run the following command to test the app in electron headless mode | ||
| ``` | ||
| npx cypress run | ||
| ``` |
Member
There was a problem hiding this comment.
Once I was actually able to get this running do to missing dependencies https://docs.cypress.io/guides/guides/continuous-integration.html#Advanced-setup
It's still gives me errors because it can't connect to http://localhost:4848 - I'm guessing the app needs to be run in docker first to run the test, so that should be mentioned here.
Member
There was a problem hiding this comment.
Did you push your change, i don't see it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added status badges
Added information for running tests
Removed info for running tests from GUI Section