feat(shared): move canvas/design/comment/pipeline types into @app/shared - #33
Open
espetro wants to merge 3 commits into
Open
feat(shared): move canvas/design/comment/pipeline types into @app/shared#33espetro wants to merge 3 commits into
espetro wants to merge 3 commits into
Conversation
Exact pin 4.0.23 shadowed the hoisted 4.0.26 that ai@6.0.175 requires, breaking @app/core's image generation module at runtime (missing isNonNullable export). Use caret range so bun dedupes to one copy.
Pure move: apps/web/src/shared/types/* now re-export from @app/shared instead of declaring the types locally. No shape changes, no consumer imports touched. Refs #27
Deploying calca with
|
| Latest commit: |
24b40cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a401bc7.calca-5u3.pages.dev |
| Branch Preview URL: | https://feat-shared-types-reorg.calca-5u3.pages.dev |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point/ToolMode(canvas),CanvasImage/DesignIteration/GenerationGroup/SummaryData(design), comment types, and pipeline types fromapps/web/src/shared/types/*intopackages/shared/src/types/*.apps/web/src/shared/types/*now re-export from@app/shared— pure move, no shape changes, no consumer imports touched.Second of 5 stacked PRs splitting an uncommitted working tree (see
.agents/plans/2026-08-20-split-uncommitted-tree-into-5-prs.md). Base:main.feat/canvas-react-flow(PR4) will rebase onto this after merge.Closes #27
Test plan
bunx turbo typecheck --filter=@app/shared --filter=@app/webapps/webtest suite: 103 tests passed (12 files), unaffected by the pure re-export