Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR upgrades Ant Design from v5 to v6 across the
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: "update cy test" |
| medium: "medium", | ||
| middle: "middle", |
There was a problem hiding this comment.
does this replace middle, or is there a middle and a medium now?
There was a problem hiding this comment.
yes it's the replacement 🥳
found this in the docs: middle is deprecated and will be removed in v7, please use medium instead.
For typechecking purposes we'll still have middle option, but any use will trigger a console warning for deprecation.
There was a problem hiding this comment.
Cool! We might as well just update those as possible in our code already and remove middle from stories.
There was a problem hiding this comment.
Yes, might as well do it now. I've updated the types to remove the middle option from storybook and changed all the middle values to medium in our code :)
Ticket ENG-2996
Description Of Changes
Upgrades Ant Design from v5 to v6 across the
fidesuiandadmin-uipackages. This is primarily a technical upgrade — most component APIs remain compatible, but v6 has a few breaking changes and deprecated props that have been addressed.Key changes:
cssVar: truefrom our theme config)Tagtovariant="filled"(no border) instead of the v5 bordered default. Fixed inCustomTagHOC to default tovariant="outlined"to preserve existing appearance, while brand-color tags that intentionally had no border continue to use"filled"All deprecated prop usages have been migrated to their v6 equivalents (see Code Changes).
Code Changes
clients/fidesui/package.json— bumpantdto^6clients/admin-ui/jest.setup.ts— Added imports for new stubs that are needed in ant v6clients/fidesui/src/ant-theme/default-theme.ts/dark-theme.ts— removecssVar: true(now always-on in v6, boolean form removed from types)clients/fidesui/src/hoc/CustomTag.tsx— replace deprecatedborderedprop withvariant, defaulting to"outlined"to preserve v5 appearanceclients/fidesui/src/hoc/CustomTable.tsx—borderedremains valid onTablein v6; no change neededclients/fidesui/src/components/feedback/Notification.stories.tsx—duration: null→false(null no longer accepted)clients/fidesui/src/components/data-display/Table.stories.tsx+Spin,PageSpinner,CustomAvatar,CustomSelectstories —SizeTypenow includes"medium"and"middle"variants; updated exhaustive Record mapsclients/admin-ui/src/features/privacy-assessments/AssessmentSettingsModal.tsx—destroyOnClose→destroyOnHidden;onDropdownVisibleChange→onOpenChangeclients/admin-ui/src/features/privacy-assessments/RequestInputModal.tsx—destroyOnClose→destroyOnHiddenclients/admin-ui/src/features/policies/conditions/AddEditPolicyConditionModal.tsx—destroyOnClose→destroyOnHiddenclients/admin-ui/src/features/digests/components/TestEmailModal.tsx—destroyOnClose→destroyOnHiddenclients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx—styles.content→styles.wrapper(contentremoved fromModalStylesTypein v6)clients/admin-ui/src/features/privacy-requests/PrivacyRequestActionsDropdown.tsx,consent/reporting/index.tsx,ActionButtons.tsx,AccountDropdownMenu.tsx,TCFConfigurationDropdown.tsx—overlayStyle→styles={{ root: ... }}clients/admin-ui/src/features/data-discovery-and-detection/action-center/tables/DiscoveredAssetsTable.tsx—overlayClassName→classNames={{ root: ... }}clients/admin-ui/src/features/consent-settings/tcf/TCFConfigurationDropdown.tsx—dropdownRender→popupRenderclients/admin-ui/src/features/privacy-requests/events-and-logs/ActivityTimeline.tsx— remove redundantbordered={false}onList(false is the default)clients/admin-ui/src/features/privacy-requests/dashboard/list-item/components/DaysLeft.tsx,MonitorFieldListItem.tsx—bordered={false}→variant="filled"onTagclients/admin-ui/src/features/privacy-requests/SubmitPrivacyRequest.tsx— replace removedDropdown.ButtonwithSpace.Compact + Button + Dropdownclients/admin-ui/src/features/common/nav/MainSideNav.tsx—popupClassNameper-item prop is still valid onSubMenuType; no change neededclients/admin-ui/src/pages/poc/form-experiments/FormikAntFormItem.tsx,FormikControlled.tsx—DatePickeronChangenow typesdateas nullable; add optional chainingSteps to Confirm
Preview link: https://fides-plus-nightly-git-upgrade-to-ant-v6-ethyca.vercel.app/
/privacy-requests, monitor status tags on/integrations, data use tags in system declarations. All should have a visible border except intentionally filled ones (the "days left" countdown tag and diff-status tags in Action Center field rows)/integrations → Add integration) — verify it is ~700px tall, the list scrolls internally, and the footer stays pinned/privacy-requests, verify the "Create request" split button: left button opens the modal, right chevron shows "Create request link", both buttons are visually joined and primary-styledPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works