Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This comment was marked as resolved.
This comment was marked as resolved.
tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_endpoints.py
Outdated
Show resolved
Hide resolved
tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_endpoints.py
Outdated
Show resolved
Hide resolved
tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_endpoints.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2737
Description Of Changes
The frontend was determining task status (error/polling/awaiting processing) by scanning execution logs returned in the verbose privacy request response. With long-lived polling tasks that produce 50+ execution logs, the 50-log limit could cause a completed task to still appear as "Awaiting Polling" in the UI.
This adds a
task_status_by_dataset_namefield to the verbose response, populated directly fromRequestTask.status. The frontend now reads task status from this field instead of inferring it from execution log history.Code Changes
task_status_by_dataset_namehelper onPrivacyRequestmodel — queriesRequestTaskrows and groups their status by dataset nametask_status_by_dataset_nametoPrivacyRequestVerboseResponseschema_shared_privacy_request_searchwhenverbose=TrueusePrivacyRequestEventLogshook to use the new field forhasPolling,hasError,hasAwaitingProcessinginstead of scanning execution logstask_status_by_dataset_nameto thePrivacyRequestEntityTypeScript typeSteps to Confirm
/api/v1/privacy-request?verbose=Trueresponse includestask_status_by_dataset_namewith correct statuses per datasetPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works