Draft
Conversation
wip:lots of ideas chore: fix wip: slowly getting there chore: formatting wip:lots of things wip:so much more thinking fix: imports chore: remove maps wip: lots of stuff done wip: one foot forward two steps back wip: minor refactors chore: wip chore: wip chore: morewip wip: getting there chore: wip feat: mostly hacked async actions chore: removing logging wip: refinements wip:some linting chore: remove poc chore:more linting chore: even more linting chore: more linting fix: state issues chore: linting fix: callback deps chore: linting
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2451
Description Of Changes
Creating a component specifically for handling async tree data.
This is not scalable due to how ant designed the component and this hacks together something that meets functional requirements.
A truly scalable component would need to be build from scratch so that individual tree elements can be properly rendered and tracked as a virtual react element that can refetch data according to it's visibility instead of a globally tracked list of nodes that may or may not be visible or relevant.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works