ENG-177: Migrate remaining Chakra toasts to Ant Design useMessage#7705
Closed
gilluminate wants to merge 6 commits intomainfrom
Closed
ENG-177: Migrate remaining Chakra toasts to Ant Design useMessage#7705gilluminate wants to merge 6 commits intomainfrom
gilluminate wants to merge 6 commits intomainfrom
Conversation
…useMessage Replace Chakra useToast with Ant Design useNotification for toasts with action links (View, navigate) and useMessage for simple success/error feedback. Delete unused SuccessToastContent helper. Fix deprecated `btn` prop to `actions` across all notification calls. Inline useAPIHelper logic for conflict-resolved files. Add shouldShowNotification Cypress helper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace all Chakra toast patterns with Ant Design useMessage across ~68 admin-ui source files, completing the toast unification effort. Delete the now-unused toast.tsx helpers and TestConnectionMessage component. Update 11 Cypress test files to use shouldShowMessage helper and 1 unit test to mock useMessage instead of useChakraToast. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
gilluminate
deleted the
gill/ENG-177/migrate-chakra-toasts-to-use-message
branch
gilluminate
added a commit
that referenced
this pull request
Mar 19, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-177
Description Of Changes
Migrate all remaining
useChakraToast/successToastParams/errorToastParamsconsumers in admin-ui to Ant DesignuseMessage, completing the toast unification effort (PR 4 of 4).After this change, zero Chakra toast patterns remain in admin-ui. The privacy-center still uses
useChakraToast, so the fidesui export is preserved for now.Code Changes
useChakraToast as useToastwithuseMessage, replacetoast(successToastParams(...))/toast(errorToastParams(...))withmessage.success(...)/message.error(...), remove~/features/common/toastimportsclients/admin-ui/src/features/common/toast.tsx- Deleted (old toast helpers:successToastParams,errorToastParams,DEFAULT_TOAST_PARAMS,SuccessMessage,ErrorMessage)clients/admin-ui/src/features/datastore-connections/system_portal_config/TestConnectionMessage.tsx- Deleted (was only used as JSX inside Chakra toast descriptions)cy.getByTestId("toast-success-msg")/cy.getByTestId("toast-error-msg")withcy.shouldShowMessage("success")/cy.shouldShowMessage("error")clients/admin-ui/__tests__/.../useAssetReportingDownload.test.ts- Update mock fromuseChakraToasttouseMessageEdge cases handled:
cells.tsx- Renamedconst message = useMessage()toconst messageApi = useMessage()to avoid collision with existingmessagepropSystemInformationForm.tsx-toast.closeAll()→message.destroy(), warning toasts →message.warning()ConnectorParameters.tsx- KeptuseAPIHelper, only migrateduseChakraToastusageAddVendor.tsx- Preserved tooltip quotingSteps to Confirm
cd clients/admin-ui && npx tsc --noEmit- should pass with no errorscd clients/admin-ui && npm run build- should succeedcd clients/admin-ui && npm run dev, trigger success/error actions across the app - messages should appear top-center with consistent Ant Design stylinguseChakraToast,successToastParams, orerrorToastParamsreferences inclients/admin-ui/src/Pre-Merge Checklist
CHANGELOG.mdupdated