fix(tool): sanitize ScriptedTool callback errors#1239
Merged
Conversation
chaliy
force-pushed
the
fix/1172-scripted-tool-error-sanitize
branch
2 times, most recently
from
2d49c9b to
df88d1a
Compare
Callback errors are now replaced with generic "callback failed" when sanitize_errors is true (the default). Full error is logged at DEBUG level. Opt out via `.sanitize_errors(false)`. Closes #1172
chaliy
force-pushed
the
fix/1172-scripted-tool-error-sanitize
branch
from
1627986 to
a276c78
Compare
Tests were asserting raw error strings but the new sanitization replaces them with generic "callback failed" messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Add
sanitize_errorsoption toScriptedToolBuilder(default:true)\n- When enabled, callbackErr(msg)is replaced with genericcallback failedin tool output\n- Full error details logged at DEBUG level for operator visibility\n- Opt out via.sanitize_errors(false)for development/debugging\n\n## Test plan\n\n- [x]test_callback_error_sanitized_by_default— internal details stripped\n- [x]test_callback_error_unsanitized_when_disabled— full error preserved when opted out\n- [x]cargo clippyandcargo fmtclean\n\nCloses #1172