Repository navigation
Make sure to avoid double refresh in background - #3
Merged
Merged
Conversation
Contributor
Author
|
I also made safeguard to ensure refershing will not stuck and continue its attempts until JWKs get expired |
Contributor
Author
|
One more commit to introduce state guard when immediate cache update is performed to make sure state is reset even if future gets cancelled |
kostas-petrikas
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing code and found potential race when performing background refresh.
So I modified test
test_background_refresh_and_expireto try to simulate race between multiple tasks attempting to perform background refresh in parallelEven under release build it is difficult to have exact reproduction
I also added multiple parallel runs to
test_timeout_policyto make sure it works ok under race friendly condition