Upgrade content-type

[blakeembrey]

Only used in

express/lib/utils.js

Lines 225 to 238 in f873ac2

	exports.setCharset = function setCharset(type, charset) {
	if (!type || !charset) {
	return type;
	}
	// parse type
	var parsed = contentType.parse(type);
	// set charset
	parsed.parameters.charset = charset;
	// format type
	return contentType.format(parsed);
	};

. There will be a minor change in behavior for invalid content-type headers as parse no longer fails but instead does its best, but the format below it will validate anything that was parsed.

This only leaves edge cases like unterminated " or trailing content after ""xyz as omitted. 100% backward compatibility can be achieved for these edge cases if its wanted, but I'm not sure it's worth it.

Version 2 of content-type was focused on performance and since this is the only method in the package using it, it's not a critical upgrade and would only serve to deduplicate with any dependencies that also upgrade.

[blakeembrey]

Including a type-is bump since it's now using content-type@2 as well.

[LinusU]

LGTM 👍

[bjohansebas]

There will be a minor change in behavior for invalid content-type headers as parse no longer fails but instead does its best, but the format below it will validate anything that was parsed.

please add tests for that case. I’m not going to block it because my time is very limited by the time you make the change, but if there are any minor changes, please add them to the tests as well.