Updating react-day-picker version#6
Open
AndrewHUNGNguyen wants to merge 2 commits intoextinctsion:mainfrom
Open
Updating react-day-picker version#6AndrewHUNGNguyen wants to merge 2 commits intoextinctsion:mainfrom
AndrewHUNGNguyen wants to merge 2 commits intoextinctsion:mainfrom
Conversation
✅ Deploy Preview for quickkurl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
I see this PR contains updating the existing library in our project. This looks good to me. Btw are you working on qr code or struck somewhere. Do we need to discuss anything? |
Author
If you mean updating existing libraries in the project as in updating react-day-picker from version 8.X.X to 9.X.X, upgrading the react-day-picker seems to cause netlify to have issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated package.json to avoid npm errors like the below issue since react-day-picker v8.10.1 is compatible with date-fns v2.28.0 -> v^3.0.0. date-fns v.4.1.0 is not compatible with react-day-picker@8.10.1. Locally, using react-day-picker@8.10.1 doesn't work locally when I do npm i or npm i qrcode, but compiles on netlify
The commit here at 9404d25 works locally when I run the npm commands to install required packages, but fails on netlify.