refactor(core): drop xds-resizable localStorage legacy fallback#3066
Merged
Conversation
Remove the LEGACY_STORAGE_PREFIX ('xds-resizable:') read-fallback from
useResizable. The primary STORAGE_PREFIX is already 'astryx-resizable:' and
all writes go there; this just drops the compat-window read of the old key.
Users with persisted panel sizes under the old key will have them reset once
on first interaction (acceptable pre-OSS). No new xds-named references remain
in useResizable.
ejhammond
requested review from
cixzhang,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
@ejhammond must be a member of the Meta Open Source team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
meta-cla
Bot
added
the
CLA Signed
Contributor
🚀 Vercel Preview Deployment
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
ejhammond
added a commit
that referenced
this pull request
Jun 24, 2026
The agent-docs CLI (xds init --features agents) now emits <!-- ASTRYX:START --> and <!-- ASTRYX:END --> markers in generated AGENTS.md/CLAUDE.md. When the script runs on a file with legacy <!-- XDS:START/END --> markers, it reads and replaces that section — the new output naturally overwrites the legacy markers with ASTRYX ones, migrating consumers on the spot. - MARKER_START/END constants now emit 'ASTRYX:START/END'. - LEGACY_MARKER_START/END kept for read-only fallback (finds existing XDS blocks). - doctor check accepts either marker set as valid. - Tests: assertions on generated output expect ASTRYX markers; fixture files with XDS markers remain to verify the legacy-read + overwrite behavior. No changeset (internal script behavior). The 'xds-resizable' localStorage key cut is a separate PR (#3066).
ejhammond
added a commit
that referenced
this pull request
Jun 24, 2026
…3067) The agent-docs CLI (xds init --features agents) now emits <!-- ASTRYX:START --> and <!-- ASTRYX:END --> markers in generated AGENTS.md/CLAUDE.md. When the script runs on a file with legacy <!-- XDS:START/END --> markers, it reads and replaces that section — the new output naturally overwrites the legacy markers with ASTRYX ones, migrating consumers on the spot. - MARKER_START/END constants now emit 'ASTRYX:START/END'. - LEGACY_MARKER_START/END kept for read-only fallback (finds existing XDS blocks). - doctor check accepts either marker set as valid. - Tests: assertions on generated output expect ASTRYX markers; fixture files with XDS markers remain to verify the legacy-read + overwrite behavior. No changeset (internal script behavior). The 'xds-resizable' localStorage key cut is a separate PR (#3066).
imdreamrunner
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
LEGACY_STORAGE_PREFIX('xds-resizable:') read-fallback fromuseResizable. The primary prefix is already'astryx-resizable:'and all writes target it; this removes the compat-window read of the old key before OSS. Users with old persisted panel sizes will have them reset once on first interaction.