fix(core): remove doubled focus ring on Selector trigger#3088
Merged
Conversation
The inner combobox button drew its own :focus-visible accent outline on top of the wrapper's :focus-within ring, stacking into a doubled, rounded outline over the trigger after selection or keyboard navigation. Defer to the wrapper's focus ring like TextInput/NumberInput.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
🚀 Vercel Preview Deployment
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
josephfarina
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3083 — a doubled focus ring ("circle covering the dropdown selector") that appears on
Selectorafter selecting an option or navigating with the keyboard.Root cause
Selector's wrapper<div>already renders the focus indicator through the sharedinputWrapperStyles.base: on:focus-withinit draws an accent border plus aninset 0 0 0 2pxring. But the inner<button role="combobox">carried its own:focus-visibleaccent outline (rounded, viaborderRadius+outlineOffset):When focus lands on that button (clicking the chevron, pressing the arrow keys, etc.), both rings render at once — the wrapper's
:focus-withinborder + inset shadow, and the button's own rounded outline stacked on top. That stacked rounded outline is the artifact in the repro.The sibling input components establish the intended pattern:
TextInputandNumberInputgive their inner focusable elementoutline: 'none'and rely solely on the wrapper's:focus-withinring.Selectordeviated from this.Fix
Remove the inner button's own
:focus-visibleoutline (and the now-unusedoutlineOffset/borderRadius) so it defers to the wrapper's focus ring, exactly like the other input components. A single, consistent focus indicator now renders.Testing
Selectorunit tests passeslintclean,tsc --noEmitclean