Skip to content

Fix image srcset parsing #7702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliankrispel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix image srcset parsing #7702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4413e
implementation works
juliankrispel Jul 18, 2025
2a39ae7
add tests
juliankrispel Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
371 changes: 371 additions & 0 deletions ...s/lexical-playground/__tests__/e2e/CopyAndPaste/html/ImageSrcsetHTMLCopyAndPaste.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,371 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
*/

import {
assertHTML,
focusEditor,
html,
initialize,
pasteFromClipboard,
sleepInsertImage,
test,
} from '../../../utils/index.mjs';

test.describe('HTML Image srcset CopyAndPaste', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));

test('Copy + paste image with srcset (width descriptors)', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img
src="https://picsum.photos/300/200"
srcset="https://picsum.photos/300/200 300w, https://picsum.photos/600/400 600w"
alt="Responsive image with width descriptors"
width="300"
height="200"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Responsive image with width descriptors"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste image with srcset (density descriptors)', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img
src="https://picsum.photos/300/200"
srcset="https://picsum.photos/300/200 1x, https://picsum.photos/600/400 2x"
alt="Responsive image with density descriptors"
width="300"
height="200"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Responsive image with density descriptors"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste image with srcset (no descriptors)', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img
src="https://picsum.photos/300/200"
srcset="https://picsum.photos/300/200, https://picsum.photos/600/400"
alt="Responsive image without descriptors"
width="300"
height="200"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Responsive image without descriptors"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste image with malformed srcset (falls back to src)', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img
src="https://picsum.photos/300/200"
srcset="invalid, srcset, format"
alt="Image with malformed srcset"
width="300"
height="200"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Image with malformed srcset"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste image with only srcset (no src fallback)', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img
srcset="https://picsum.photos/300/200 300w, https://picsum.photos/600/400 600w"
alt="Image with only srcset"
width="300"
height="200"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Image with only srcset"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste image with data URL in srcset', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const dataUrl = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNkYPhfDwAChwGA60e6kgAAAABJRU5ErkJggg==';

const clipboard = {
'text/html': `
<img
src="${dataUrl}"
srcset="${dataUrl} 1x, ${dataUrl} 2x"
alt="Image with data URL in srcset"
width="1"
height="1"
/>
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage();

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Image with data URL in srcset"
draggable="false"
src="${dataUrl}"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});

test('Copy + paste multiple images with different srcset formats', async ({
page,
isPlainText,
}) => {
test.skip(isPlainText);

await focusEditor(page);

const clipboard = {
'text/html': `
<img src="https://picsum.photos/300/200" srcset="https://picsum.photos/300/200 300w, https://picsum.photos/600/400 600w" alt="Width descriptors" />
<img src="https://picsum.photos/400/300" srcset="https://picsum.photos/400/300 1x, https://picsum.photos/800/600 2x" alt="Density descriptors" />
<img src="https://picsum.photos/500/400" srcset="https://picsum.photos/500/400, https://picsum.photos/1000/800" alt="No descriptors" />
`,
};

await pasteFromClipboard(page, clipboard);
await sleepInsertImage(3);

await assertHTML(
page,
html`
<p
class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
dir="ltr">
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Width descriptors"
draggable="false"
src="https://picsum.photos/300/200"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="Density descriptors"
draggable="false"
src="https://picsum.photos/400/300"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<span
class="editor-image"
contenteditable="false"
data-lexical-decorator="true">
<div draggable="false">
<img
alt="No descriptors"
draggable="false"
src="https://picsum.photos/500/400"
style="height: inherit; max-width: 500px; width: inherit" />
</div>
</span>
<br />
</p>
`,
);
});
});

Check failure on line 371 in packages/lexical-playground/__tests__/e2e/CopyAndPaste/html/ImageSrcsetHTMLCopyAndPaste.spec.mjs

View workflow job for this annotation

GitHub Actions / core-tests / integrity (20.11.0) 

Newline required at end of file but not found
Loading
Loading