Added rsocket-cpp dependency to Ubuntu 16.04 build script#306
Open
orishu wants to merge 1 commit intofacebook:mainfrom
Open
Added rsocket-cpp dependency to Ubuntu 16.04 build script#306orishu wants to merge 1 commit intofacebook:mainfrom
orishu wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orishu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Travis build started failing since fbthrift became dependent of rsocket-cpp.
Sample failure: https://travis-ci.org/facebook/mcrouter/builds/489841577
Added a new recipe for rsocket-cpp and included it in the Ubuntu 16.04 scripts.
Test Plan:
./mcrouter/scripts/install_ubuntu_16.04.sh "$(pwd)"/mcrouter-installsucceeded on an Ubuntu 16.04 VM.