Refactor: Clean up bindings installation #54974
Open
+94
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
RSNara
force-pushed
the
export-D89709216
branch
2 times, most recently
from
7bd218c to
50a8eda
Compare
Summary: The TurboModuleBinding constructor actually doesn't need to be public! It's only called from BridgelessTurboModuleProxy or TurboModuleBinding::install. Changelog: [General][Breaking] Make the TurboModuleBinding constructor private. Reviewed By: christophpurrer Differential Revision: D89751218
Summary: This way we can stop capturing the runtime pointer inside the providers created by turbomodule manager delegate. ## iOS https://www.internalfb.com/code/fbsource/[bf6c0a76ea2c967a93b6bc2b8977cac23211ec0d]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm?lines=919-920%2C946%2C969 ## Android https://www.internalfb.com/code/fbsource/[d226c31f345fd69c8453d4c8270b0df083c64ad5]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.cpp?lines=128-132%2C144-145 Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D89751221
Summary: Holding a reference to the runtime is discouraged. Let's just use the reference provided to the turbomodule binding instead. Changelog: [General][Deprecated] Deprecate TurboModuleProviderFunctionType Reviewed By: christophpurrer Differential Revision: D89751220
Summary: Read from react native feaure flags from within TurboModuleManager. This makes it easier to call installJSIBindings. The caller doesn't have to read from feature flags beforehand. Changelog: [Android][Breaking] Remove unstable_shouldEnableLegacyModuleInterop() Reviewed By: christophpurrer Differential Revision: D89709217
Summary: The runtime executor is only used to install jsi bindings. So, let's just pass it directly to the installJSIBindings function. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D89709216
RSNara
force-pushed
the
export-D89709216
branch
from
50a8eda to
2e6fa90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The runtime executor is only used to install jsi bindings. So, let's just pass it directly to the installJSIBindings function.
Changelog: [Internal]
Differential Revision: D89709216