feat(nimble): Add column-pruning Deserializer overload (#975)#975
Closed
duxiao1212 wants to merge 1 commit into
Closed
feat(nimble): Add column-pruning Deserializer overload (#975)#975duxiao1212 wants to merge 1 commit into
duxiao1212 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112019764. |
meta-codesync
Bot
changed the title
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 17, 2026
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, newState->leafPool.get(), buildWeightProjectSubfields(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 05:35
05a2e98 to
f88e9de
Compare
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 17, 2026
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, buildWeightProjectSubfields(), newState->leafPool.get(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 16:09
f88e9de to
89455d5
Compare
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 17, 2026
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, buildWeightProjectSubfields(), newState->leafPool.get(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 16:21
89455d5 to
aedb0fb
Compare
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 17, 2026
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, buildWeightProjectSubfields(), newState->leafPool.get(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 16:23
aedb0fb to
23ad13c
Compare
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 17, 2026
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, buildWeightProjectSubfields(), newState->leafPool.get(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 16:55
23ad13c to
8b733d4
Compare
…ator#975) Summary: Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields. So that deserializer can directly uses as ``` weightDeserializer = std::make_unique<nimble::Deserializer>( nimbleInputSchema_, buildWeightProjectSubfields(), newState->leafPool.get(), weightSelectorOptions, weightDeserializerOptions); } ... nimble.weightDeserializer->deserialize(rawValues, nimble.weightVector); ``` Differential Revision: D112019764
duxiao1212
force-pushed
the
export-D112019764
branch
from
July 17, 2026 18:51
8b733d4 to
a040d86
Compare
xiaoxmeng
approved these changes
Jul 17, 2026
|
This pull request has been merged in c8baf7c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a column-pruning Deserializer constructor that accepts selected Velox Subfields and builds a reader tree for only those Row fields.
So that deserializer can directly uses as
Differential Revision: D112019764