add kcb_identity field on RequestCommon + thrift header write#674
Open
ghuryejay wants to merge 1 commit into
Open
add kcb_identity field on RequestCommon + thrift header write#674ghuryejay wants to merge 1 commit into
ghuryejay wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Summary: X-link: facebook/mcrouter#480 Adds the `kcbIdentity` field to `carbon::RequestCommon` (mirrors the existing `clientIdentifier` and `cryptoAuthToken` fields), and updates the carbon compiler template to emit a `setWriteHeader(kKcbIdentityHeader, ...)` block in every generated `*ThriftTransport.h`. This is the wire-format support for Generalized KCB: callers set `request.setKcbIdentity(aclName)` and the transport writes the `kcb_identity` thrift header on the outgoing thrift call so the UCache server can bind the cache key to the named ACL group Reviewed By: antonf Differential Revision: D104245265
ghuryejay
force-pushed
the
export-D104245265-to-v2-beta
branch
from
cc45354 to
8f22e87
Compare
meta-codesync Bot
pushed a commit
to facebook/mcrouter
that referenced
this pull request
Jun 1, 2026
Summary: X-link: facebookresearch/DCPerf#674 Pull Request resolved: #480 Adds the `kcbIdentity` field to `carbon::RequestCommon` (mirrors the existing `clientIdentifier` and `cryptoAuthToken` fields), and updates the carbon compiler template to emit a `setWriteHeader(kKcbIdentityHeader, ...)` block in every generated `*ThriftTransport.h`. This is the wire-format support for Generalized KCB: callers set `request.setKcbIdentity(aclName)` and the transport writes the `kcb_identity` thrift header on the outgoing thrift call so the UCache server can bind the cache key to the named ACL group Reviewed By: antonf Differential Revision: D104245265 fbshipit-source-id: 07c975c74a1dd8f5feb0bfac064b7301204a491a
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 1, 2026
Summary: Pull Request resolved: #674 X-link: facebook/mcrouter#480 Adds the `kcbIdentity` field to `carbon::RequestCommon` (mirrors the existing `clientIdentifier` and `cryptoAuthToken` fields), and updates the carbon compiler template to emit a `setWriteHeader(kKcbIdentityHeader, ...)` block in every generated `*ThriftTransport.h`. This is the wire-format support for Generalized KCB: callers set `request.setKcbIdentity(aclName)` and the transport writes the `kcb_identity` thrift header on the outgoing thrift call so the UCache server can bind the cache key to the named ACL group Reviewed By: antonf Differential Revision: D104245265 fbshipit-source-id: 07c975c74a1dd8f5feb0bfac064b7301204a491a
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jun 3, 2026
Summary: X-link: facebookresearch/DCPerf#674 X-link: facebook/mcrouter#480 Adds the `kcbIdentity` field to `carbon::RequestCommon` (mirrors the existing `clientIdentifier` and `cryptoAuthToken` fields), and updates the carbon compiler template to emit a `setWriteHeader(kKcbIdentityHeader, ...)` block in every generated `*ThriftTransport.h`. This is the wire-format support for Generalized KCB: callers set `request.setKcbIdentity(aclName)` and the transport writes the `kcb_identity` thrift header on the outgoing thrift call so the UCache server can bind the cache key to the named ACL group Reviewed By: antonf Differential Revision: D104245265 fbshipit-source-id: 07c975c74a1dd8f5feb0bfac064b7301204a491a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/mcrouter#480
Adds the
kcbIdentityfield tocarbon::RequestCommon(mirrors the existingclientIdentifierandcryptoAuthTokenfields), and updates the carbon compiler template to emit asetWriteHeader(kKcbIdentityHeader, ...)block in every generated*ThriftTransport.h. This is the wire-format support for Generalized KCB: callers setrequest.setKcbIdentity(aclName)and the transport writes thekcb_identitythrift header on the outgoing thrift call so the UCache server can bind the cache key to the named ACL groupReviewed By: antonf
Differential Revision: D104245265