Add standalone cpu-pidstat Benchpress hook#677
Open
aashvibusa wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@aashvibusa has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107446848. |
Summary: Add a standalone cpu-pidstat Benchpress hook for collecting per-process and per-thread CPU utilization during benchmark runs. The new hook starts pidstat in the background before a job, writes raw pidstat output into the benchmark metrics directory, and terminates the background process after the job completes. This mirrors the existing cpu-mpstat standalone hook pattern while keeping the standalone pidstat hook separate from perf hook sub-monitors. Also registers the hook as cpu-pidstat and adds unit coverage for default options, custom args, graceful shutdown, and forced termination. Differential Revision: D107446848
aashvibusa
force-pushed
the
export-D107446848-to-v2-beta
branch
from
e6cb7eb to
c155d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a standalone cpu-pidstat Benchpress hook for collecting per-process and per-thread CPU utilization during benchmark runs.
The new hook starts pidstat in the background before a job, writes raw pidstat output into the benchmark metrics directory, and terminates the background process after the job completes. This mirrors the existing cpu-mpstat standalone hook pattern while keeping the standalone pidstat hook separate from perf hook sub-monitors.
Also registers the hook as cpu-pidstat and adds unit coverage for default options, custom args, graceful shutdown, and forced termination.
Differential Revision: D107446848