Fix benchpress skycastle entrypoint names to match workflow definitions (#688)#688
Open
ahmadelyoussef wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@ahmadelyoussef has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108346882. |
meta-codesync
Bot
changed the title
ahmadelyoussef
added a commit
to ahmadelyoussef/DCPerf
that referenced
this pull request
Jun 18, 2026
…ns (facebookresearch#688) Summary: The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882
ahmadelyoussef
force-pushed
the
export-D108346882-to-v2-beta
branch
from
16f4e0e to
6121106
Compare
ahmadelyoussef
added a commit
to ahmadelyoussef/DCPerf
that referenced
this pull request
Jun 18, 2026
…ns (facebookresearch#688) Summary: The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882
ahmadelyoussef
force-pushed
the
export-D108346882-to-v2-beta
branch
from
6121106 to
48d3e88
Compare
ahmadelyoussef
added a commit
to ahmadelyoussef/DCPerf
that referenced
this pull request
Jun 23, 2026
…ns (facebookresearch#688) Summary: The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882
ahmadelyoussef
force-pushed
the
export-D108346882-to-v2-beta
branch
from
48d3e88 to
6246f21
Compare
ahmadelyoussef
added a commit
to ahmadelyoussef/DCPerf
that referenced
this pull request
Jun 23, 2026
…ns (facebookresearch#688) Summary: The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882
ahmadelyoussef
force-pushed
the
export-D108346882-to-v2-beta
branch
from
6246f21 to
aed6c91
Compare
…ns (facebookresearch#688) Summary: The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882
ahmadelyoussef
force-pushed
the
export-D108346882-to-v2-beta
branch
from
aed6c91 to
b855e3f
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
…ns (#688) Summary: Pull Request resolved: #688 The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky. Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file Reviewed By: excelle08 Differential Revision: D108346882 fbshipit-source-id: bf9c2b0e77240f0aa041cc37942c115ec7a98e78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The BUCK file defined ci_skycastle targets with entrypoint names that did not match the entry_point names defined in tools/skycastle/workflows2/dc_perf/benchpress.sky.
Updated all 16 ci_skycastle targets to use the correct entrypoint names that match the entry_point definitions in the sky file
Reviewed By: excelle08
Differential Revision: D108346882