Add self-contained tao_bench fbpkg build via buck_genrule (#701)#701
Open
ahmadelyoussef wants to merge 3 commits into
Open
Add self-contained tao_bench fbpkg build via buck_genrule (#701)#701ahmadelyoussef wants to merge 3 commits into
ahmadelyoussef wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@ahmadelyoussef has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110112328. |
meta-codesync
Bot
changed the title
ahmadelyoussef
added a commit
to ahmadelyoussef/DCPerf
that referenced
this pull request
Jun 29, 2026
…search#701) Summary: Add self-contained TaoBench fbpkg build via buck_genrule to enable pre-built TaoBench binaries (tao_bench_server + tao_bench_client) in the cea.chips.benchpress.oss_prebuild fbpkg. TaoBench will now be pre-built at fbpkg build time for both x86_64 and aarch64 architectures, eliminating the need to run `benchpress install` on target machines. Uses cmake directly (not getdeps.py) to build folly and all dependencies with static linking + LTO for better performance and zero runtime library dependencies. Key changes: - `fb_scripts/builder/tao_bench/`: build.sh, download_deps.sh, upload_deps_to_manifold.sh, create_prepatched_memcached.sh, create_prepatched_memtier.sh, upload_memtier_to_manifold.sh - BUCK: tao_bench genrules (deps_download, x86 build, arm64 build) + fbpkg path_actions for both architectures - Pre-patched tarballs for memcached (7 patches) and memtier (1 patch) uploaded to Manifold, so RE builds don't need `patch` or `autoreconf` Differential Revision: D110112328
ahmadelyoussef
force-pushed
the
export-D110112328-to-v2-beta
branch
from
f9bdcb5 to
875d763
Compare
…kresearch#697) Summary: Add self-contained HealthCheck fbpkg build via buck_genrule to enable pre-built HealthCheck binaries in the cea.chips.benchpress.oss_prebuild fbpkg. The HealthCheck benchmark will now be pre-built at fbpkg build time for both x86_64 and aarch64 architectures, eliminating the need to run benchpress install on target machines. Reviewed By: excelle08 Differential Revision: D108812377
…acebookresearch#698) Summary: Pre-build syscall and schbench at fbpkg build time so the package runs without `benchpress install`. **Syscall**: custom genrule build (same two-stage pattern as feedsim/health_check). Downloads gflags from Manifold, compiles syscall.cpp with static gflags linkage. **Schbench**: uses existing `//third-party/schbench:schbench` cpp_binary target directly via fbpkg.copy(). No custom build scripts or Manifold deps needed since the source is already in fbsource. Key changes: - `fb_scripts/builder/syscall/`: build.sh, download_deps.sh, upload_deps_to_manifold.sh for syscall genrule build - BUCK: syscall genrules (deps_download, x86 build, arm64 build) + schbench via fbpkg.copy from //third-party/schbench:schbench - `benchmarks_system.yml`: added install_markers for prebuild detection Reviewed By: excelle08 Differential Revision: D108812394
…search#701) Summary: Add self-contained TaoBench fbpkg build via buck_genrule to enable pre-built TaoBench binaries (tao_bench_server + tao_bench_client) in the cea.chips.benchpress.oss_prebuild fbpkg. TaoBench will now be pre-built at fbpkg build time for both x86_64 and aarch64 architectures, eliminating the need to run `benchpress install` on target machines. Uses cmake directly (not getdeps.py) to build folly and all dependencies with static linking + LTO for better performance and zero runtime library dependencies. Key changes: - `fb_scripts/builder/tao_bench/`: build.sh, download_deps.sh, upload_deps_to_manifold.sh, create_prepatched_memcached.sh, create_prepatched_memtier.sh, upload_memtier_to_manifold.sh - BUCK: tao_bench genrules (deps_download, x86 build, arm64 build) + fbpkg path_actions for both architectures - Pre-patched tarballs for memcached (7 patches) and memtier (1 patch) uploaded to Manifold, so RE builds don't need `patch` or `autoreconf` Differential Revision: D110112328
ahmadelyoussef
force-pushed
the
export-D110112328-to-v2-beta
branch
from
875d763 to
b98141e
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
Summary: Pull Request resolved: #701 Add self-contained TaoBench fbpkg build via buck_genrule to enable pre-built TaoBench binaries (tao_bench_server + tao_bench_client) in the cea.chips.benchpress.oss_prebuild fbpkg. TaoBench will now be pre-built at fbpkg build time for both x86_64 and aarch64 architectures, eliminating the need to run `benchpress install` on target machines. Uses cmake directly (not getdeps.py) to build folly and all dependencies with static linking + LTO for better performance and zero runtime library dependencies. Key changes: - `fb_scripts/builder/tao_bench/`: build.sh, download_deps.sh, upload_deps_to_manifold.sh, create_prepatched_memcached.sh, create_prepatched_memtier.sh, upload_memtier_to_manifold.sh - BUCK: tao_bench genrules (deps_download, x86 build, arm64 build) + fbpkg path_actions for both architectures - Pre-patched tarballs for memcached (7 patches) and memtier (1 patch) uploaded to Manifold, so RE builds don't need `patch` or `autoreconf` Reviewed By: excelle08 Differential Revision: D110112328 fbshipit-source-id: 828fb2a33c57f4bd5893c812ed4a112672807151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add self-contained TaoBench fbpkg build via buck_genrule to enable pre-built
TaoBench binaries (tao_bench_server + tao_bench_client) in the
cea.chips.benchpress.oss_prebuild fbpkg. TaoBench will now be pre-built at
fbpkg build time for both x86_64 and aarch64 architectures, eliminating the
need to run
benchpress installon target machines.Uses cmake directly (not getdeps.py) to build folly and all dependencies with
static linking + LTO for better performance and zero runtime library dependencies.
Key changes:
fb_scripts/builder/tao_bench/: build.sh, download_deps.sh,upload_deps_to_manifold.sh, create_prepatched_memcached.sh,
create_prepatched_memtier.sh, upload_memtier_to_manifold.sh
fbpkg path_actions for both architectures
uploaded to Manifold, so RE builds don't need
patchorautoreconfDifferential Revision: D110112328