Add hackperf headline metric and canonical metric-name mappings#703
Add hackperf headline metric and canonical metric-name mappings#703Ryanjmeek wants to merge 1 commit into
Conversation
Summary: Split out of D98822202 — the perfpub-only portion, separated because perfpub (fbcode/cea/chips/perfpub) is open-sourced independently of the hackperf benchmark. In process_metrics() (both utils.py and utils_internal.py), extract hackperf's Requests/sec headline metric into db_fields["metrics"] so it is recorded and surfaced in overall-metrics.csv. Also add canonical metric-name mappings so hackperf's perf-counter labels resolve to PerfPub's canonical fields (Frontend/Backend Bound %, Retiring %, Bad Speculation %, and the *-PKI variants for branch/L1I/L1D/iTLB/dTLB). Note: perfpub is open-sourced; this diff needs to be exported alongside the DCPerf OSS export. Differential Revision: D109589981
meta-cla
Bot
added
the
CLA Signed
|
@Ryanjmeek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109589981. |
Summary: Pull Request resolved: #703 Split out of D98822202 — the perfpub-only portion, separated because perfpub (fbcode/cea/chips/perfpub) is open-sourced independently of the hackperf benchmark. In process_metrics() (both utils.py and utils_internal.py), extract hackperf's Requests/sec headline metric into db_fields["metrics"] so it is recorded and surfaced in overall-metrics.csv. Also add canonical metric-name mappings so hackperf's perf-counter labels resolve to PerfPub's canonical fields (Frontend/Backend Bound %, Retiring %, Bad Speculation %, and the *-PKI variants for branch/L1I/L1D/iTLB/dTLB). Note: perfpub is open-sourced; this diff needs to be exported alongside the DCPerf OSS export. Reviewed By: excelle08 Differential Revision: D109589981 fbshipit-source-id: 7101ee1d5ba7109c77dece1a7284818cbecaf56a
|
Hi @Ryanjmeek! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Summary:
Split out of D98822202 — the perfpub-only portion, separated because perfpub (fbcode/cea/chips/perfpub) is open-sourced independently of the hackperf benchmark.
In process_metrics() (both utils.py and utils_internal.py), extract hackperf's Requests/sec headline metric into db_fields["metrics"] so it is recorded and surfaced in overall-metrics.csv. Also add canonical metric-name mappings so hackperf's perf-counter labels resolve to PerfPub's canonical fields (Frontend/Backend Bound %, Retiring %, Bad Speculation %, and the *-PKI variants for branch/L1I/L1D/iTLB/dTLB).
Note: perfpub is open-sourced; this diff needs to be exported alongside the DCPerf OSS export.
Differential Revision: D109589981