feedsim: reuse existing conda install when available#748
Open
NikhilTarte-Arm wants to merge 1 commit into
Open
feedsim: reuse existing conda install when available#748NikhilTarte-Arm wants to merge 1 commit into
NikhilTarte-Arm wants to merge 1 commit into
Conversation
The Ubuntu aarch64 FeedSim installer always attempted to download and bootstrap Miniconda before installing the CPU-only torch wheel used to provide LibTorch. Reuse an existing conda installation when one is already available by creating the benchmark-local conda prefix from that conda instead of always downloading Miniconda. Keep the existing Miniconda download path as the fallback when conda is not present. This preserves the local benchmark environment layout, avoids unnecessary Miniconda bootstrapping when conda is already provisioned, and only accepts Anaconda TOS when the installer actually bootstraps Miniconda itself.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ubuntu aarch64 FeedSim installer always attempted to download and bootstrap Miniconda before installing the CPU-only torch wheel used to provide LibTorch.
Reuse an existing conda installation when one is already available by creating the benchmark-local conda prefix from that conda instead of always downloading Miniconda. Keep the existing Miniconda download path as the fallback when conda is not present.
This preserves the local benchmark environment layout, avoids unnecessary Miniconda bootstrapping when conda is already provisioned, and only accepts Anaconda TOS when the installer actually bootstraps Miniconda itself.