Skip to content

Add SearchParameters in ParameterSpace::explore#5236

Open
jbajic wants to merge 9 commits into
facebookresearch:mainfrom
jbajic:enable-search-parameters-autotune
Open

Add SearchParameters in ParameterSpace::explore#5236
jbajic wants to merge 9 commits into
facebookresearch:mainfrom
jbajic:enable-search-parameters-autotune

Conversation

@jbajic

@jbajic jbajic commented May 26, 2026

Copy link
Copy Markdown
Contributor

Enable passing SearchParameters to the ParameterSpace::explore function so different configurations can be passed to get different results for autotuning or to even set up different iteration mechanisms in some cases (e.g., IVF indexes have InvertedListsIterator where we can control how to iterate and might have expectations on getting the proper SearchParameters structure)

This is about solving the problem when the index has params == nullptr it uses nProbe from the index otherwise, it uses the nProbe from params. So when we pass params to the explore function, not purely for optimizing but for giving the proper context down to the iterators, we need to enable reading these optimization params from the params as well.

@meta-cla meta-cla Bot added the CLA Signed label May 26, 2026
@jbajic jbajic changed the title Enable search parameters autotune Add SearchParameters in ParameterSpace::explore May 26, 2026
@meta-codesync

meta-codesync Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@mnorris11 has imported this pull request. If you are a Meta employee, you can view this in D107264346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants