Add SearchParameters in ParameterSpace::explore#5236
Open
jbajic wants to merge 9 commits into
Open
Conversation
SearchParameters in ParameterSpace::explore
Contributor
|
@mnorris11 has imported this pull request. If you are a Meta employee, you can view this in D107264346. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable passing
SearchParametersto theParameterSpace::explorefunction so different configurations can be passed to get different results for autotuning or to even set up different iteration mechanisms in some cases (e.g., IVF indexes have InvertedListsIterator where we can control how to iterate and might have expectations on getting the properSearchParametersstructure)This is about solving the problem when the index has
params == nullptrit usesnProbefrom the index otherwise, it uses thenProbefromparams. So when we passparamsto the explore function, not purely for optimizing but for giving the proper context down to the iterators, we need to enable reading these optimization params from theparamsas well.