Omit the directory and show the distance#148
Open
Herbie34 wants to merge 4 commits intofacundoolano:mainfrom
Open
Omit the directory and show the distance#148Herbie34 wants to merge 4 commits intofacundoolano:mainfrom
Herbie34 wants to merge 4 commits intofacundoolano:mainfrom
Conversation
Contributor
Author
|
On Linux, components[0] is just '/', so it might be better to also add components[1]. |
Owner
|
Can you show some before/after examples of this? Perhaps a better option than the ... would be to show a compact version of the path segments, eg. my shell prompt does something like this: |
Contributor
Author
|
Before(use After(add components[1]): It might be a good idea to display only the first character of each directory, but I thought it might get quite long when you go deep into directories for quests... |
Owner
|
Gotcha, let me think about this for a bit. |
On Linux, components[0] is just '/', so it might be better to also add components[1].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've completed all the quests! The game balance was perfect, and I really enjoyed it.
By the way, I was wondering if it's fine to omit the display of the current directory.
Also, I thought it might be a good idea to show the distance. What do you think?
(I don't have any experience with Rust development, so I apologize if anything is incorrect.)