Skip to content

chore(deps): update dependency typescript to v6 - #3993

Merged
Shinigami92 merged 2 commits into
nextfrom
chore-typescript-6
Aug 15, 2026
Merged

chore(deps): update dependency typescript to v6#3993
Shinigami92 merged 2 commits into
nextfrom
chore-typescript-6

Conversation

@Shinigami92

Copy link
Copy Markdown
Member

#3772 v7 is blocked by TS7.1 programmatic API implementation

so this is the intermediate already v6 upgrade

@Shinigami92 Shinigami92 added this to the v11.0 milestone Aug 15, 2026
@Shinigami92 Shinigami92 self-assigned this Aug 15, 2026
@Shinigami92 Shinigami92 added the breaking change Cannot be merged when next version is not a major release label Aug 15, 2026
@netlify

netlify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 1a48ae3
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a80b2f50bd5ba0008e1ea43
😎 Deploy Preview https://deploy-preview-3993.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.98%. Comparing base (04dc415) to head (1a48ae3).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3993   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         926      926           
  Lines        3246     3246           
  Branches      582      569   -13     
=======================================
  Hits         3213     3213           
  Misses         29       29           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/helpers/module.ts 94.84% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92
Shinigami92 marked this pull request as ready for review August 15, 2026 07:55
@Shinigami92
Shinigami92 requested a review from a team as a code owner August 15, 2026 07:55
ST-DDT
ST-DDT previously approved these changes Aug 15, 2026

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a renovate supressions for v7<v7.1 so we dont get bothered by update notification

Comment thread src/modules/helpers/module.ts Outdated
Comment thread src/modules/helpers/module.ts Outdated
@Shinigami92

Copy link
Copy Markdown
Member Author

Maybe add a renovate supressions for v7<v7.1 so we dont get bothered by update notification

afaik TS7.1 is just around the corner in around 2-4 weeks, adding such temp thing to renovate config would mean at least 2 commits in next branch, IMO not worth it

ST-DDT
ST-DDT previously approved these changes Aug 15, 2026
@xDivisionByZerox

Copy link
Copy Markdown
Member

afaik TS7.1 is just around the corner in around 2-4 weeks, adding such temp thing to renovate config would mean at least 2 commits in next branch, IMO not worth it

Does that mean you plan on jumping directly to TS 7.1 for v11? Does this mean users would also require that TS version to use Faker v11? If so, that would be a pretty big jumpt no?

@Shinigami92

Copy link
Copy Markdown
Member Author

Does that mean you plan on jumping directly to TS 7.1 for v11?

yes

Does this mean users would also require that TS version to use Faker v11?

no

If so, that would be a pretty big jumpt no?

no

@Shinigami92
Shinigami92 added this pull request to the merge queue Aug 15, 2026
Merged via the queue into next with commit dcaffc1 Aug 15, 2026
23 checks passed
@Shinigami92
Shinigami92 deleted the chore-typescript-6 branch August 15, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants