Skip to content

infra: revert oxfmt config changes - #4039

Merged
ST-DDT merged 1 commit into
nextfrom
infra/format/config-cleanup
Sep 11, 2026
Merged

infra: revert oxfmt config changes#4039
ST-DDT merged 1 commit into
nextfrom
infra/format/config-cleanup

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Sep 4, 2026

Copy link
Copy Markdown
Member

Cleanup oxfmt config, because the previous changes did not work as expected.

Elements inside nested arrays are treated as the same level, thus splitting type imports from value imports doesn't have an impact.

@ST-DDT ST-DDT added this to the v11.0 milestone Sep 4, 2026
@ST-DDT ST-DDT self-assigned this Sep 4, 2026
@ST-DDT
ST-DDT requested a review from a team as a code owner September 4, 2026 17:14
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Sep 4, 2026
@netlify

netlify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f2cbc73
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a9bf593149d780008a3d124
😎 Deploy Preview https://deploy-preview-4039.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (0e0c2b7) to head (f2cbc73).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4039      +/-   ##
==========================================
+ Coverage   98.95%   99.01%   +0.05%     
==========================================
  Files         933      933              
  Lines        3334     3334              
  Branches      606      606              
==========================================
+ Hits         3299     3301       +2     
+ Misses         31       29       -2     
  Partials        4        4              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration cleanup is valid, focused, and preserves existing behavior.

Pull request overview

Simplifies the oxfmt import-sorting configuration without changing grouping behavior.

Changes:

  • Replaces nested type/value import groups with equivalent category names.
File summaries
File Description
oxfmt.config.ts Simplifies import sorting groups.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread oxfmt.config.ts Outdated
@ST-DDT
ST-DDT force-pushed the infra/format/config-cleanup branch from dc8b9a2 to f2cbc73 Compare September 5, 2026 10:57
@ST-DDT ST-DDT changed the title infra: cleanup oxfmt config infra: revert oxfmt config changes Sep 5, 2026
@ST-DDT

ST-DDT commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@Shinigami92 IMO that those are a bunch of non arguments.

I wasted enough of my time with this formatting/lint changes. So here you go.

Sorry for bothering.

@Shinigami92

Copy link
Copy Markdown
Member

@Shinigami92 IMO that those are a bunch of non arguments.

I disagree

I wasted enough of my time with this formatting/lint changes. So here you go.

Thanks for accepting the revert suggestion, however your comment sound emotional to me and I would like to tell that nobody asked you to set time into that. #4022 came up on free will from your side.
Also oxfmt vs prettier is nowadays a non-negotiable think for me, cause oxfmt is sooooo damn much faster, and therefore giving also you time back instead of waiting for local tinkering and CI/CD waiting.

But as you see, we might now get help in the long run from @leaysgur maybe, which I don't know yet 👀
@leaysgur feel free to ping me in the oxc Discord if you want fast communication 🙂 I send you also a friend inv there.

@ST-DDT
ST-DDT added this pull request to the merge queue Sep 11, 2026
Merged via the queue into next with commit c645e7e Sep 11, 2026
27 checks passed
@ST-DDT
ST-DDT deleted the infra/format/config-cleanup branch September 11, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants