infra: revert oxfmt config changes - #4039
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4039 +/- ##
==========================================
+ Coverage 98.95% 99.01% +0.05%
==========================================
Files 933 933
Lines 3334 3334
Branches 606 606
==========================================
+ Hits 3299 3301 +2
+ Misses 31 29 -2
Partials 4 4 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The configuration cleanup is valid, focused, and preserves existing behavior.
Pull request overview
Simplifies the oxfmt import-sorting configuration without changing grouping behavior.
Changes:
- Replaces nested type/value import groups with equivalent category names.
File summaries
| File | Description |
|---|---|
oxfmt.config.ts |
Simplifies import sorting groups. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This reverts commit 136cef0.
dc8b9a2 to
f2cbc73
Compare
|
@Shinigami92 IMO that those are a bunch of non arguments. I wasted enough of my time with this formatting/lint changes. So here you go. Sorry for bothering. |
I disagree
Thanks for accepting the revert suggestion, however your comment sound emotional to me and I would like to tell that nobody asked you to set time into that. #4022 came up on free will from your side. But as you see, we might now get help in the long run from @leaysgur maybe, which I don't know yet 👀 |
Cleanup oxfmt config, because the previous changes did not work as expected.
Elements inside nested arrays are treated as the same level, thus splitting type imports from value imports doesn't have an impact.