Exclude hidden commands from command suggestions#1901
Draft
hsusul wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hidden commands were included when Typer generated typo suggestions, exposing command names intentionally omitted from help output.
Suggestion candidates are now filtered using each command's
hiddenstatus. Visible-command suggestions remain unchanged, and hidden commands remain directly invokable by their exact names.Tests
Added regression coverage for both Rich and plain Click-style error rendering, verifying that:
Validation
uv run pytest tests/test_suggest_commands.py tests/test_hidden.py tests/test_rich_utils.py -quv run bash scripts/lint.shenv -u NO_COLOR TERM=xterm-256color uv run bash scripts/test.shgit diff --check