Skip to content

Conversation

@rtkevin
Copy link
Contributor

@rtkevin rtkevin commented Aug 15, 2024

Need to resolveRef here else buildArrayTypeCondition is given undefined item.type and returns undefined, which is falsy so throws the Item at i does not match schema definition error.

Checklist

added test that fails in current master and does not fail in patch.

Signed-off-by: rtkevin <kevin@rtvision.com>
Signed-off-by: rtkevin <kevin@rtvision.com>
@kalvenschraut
Copy link
Contributor

@climba03003 @ivan-tymoshenko
Any thoughts or path forward for this issue? We are currently maintaining a patch with this fix. Open to really any direction as we provided our test case where we were experiencing the problem. LMK if you need anything more from us.

@kalvenschraut
Copy link
Contributor

@mcollina @climba03003 @Eomm

not sure who can give some feedback on this but my company has been forced to maintain a patch and with the last update I had to re-update it since had to fix two areas instead of one per my last commit on this PR. I looked into one of the questions on the review comment with a response and we have a test case that shows the problem we are trying to solve so is there anything we can do to help push this through or something similar to resolve our test case?

@climba03003
Copy link
Member

climba03003 commented Feb 3, 2026

@kalvenschraut
I believe the fix can be landed after fixing the linting error.

@kalvenschraut
Copy link
Contributor

@climba03003 thanks for looking at this again!

linting issues are fixed

@climba03003 climba03003 removed the request for review from ivan-tymoshenko February 6, 2026 02:32
@climba03003 climba03003 merged commit 7e1cd78 into fastify:main Feb 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants