-
-
Notifications
You must be signed in to change notification settings - Fork 207
Handle items: [{ $ref }] #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rtkevin <kevin@rtvision.com>
Signed-off-by: rtkevin <kevin@rtvision.com>
|
@climba03003 @ivan-tymoshenko |
|
not sure who can give some feedback on this but my company has been forced to maintain a patch and with the last update I had to re-update it since had to fix two areas instead of one per my last commit on this PR. I looked into one of the questions on the review comment with a response and we have a test case that shows the problem we are trying to solve so is there anything we can do to help push this through or something similar to resolve our test case? |
|
@kalvenschraut |
|
@climba03003 thanks for looking at this again! linting issues are fixed |
Need to resolveRef here else buildArrayTypeCondition is given undefined item.type and returns undefined, which is falsy so throws the Item at i does not match schema definition error.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
added test that fails in current master and does not fail in patch.