-
Notifications
You must be signed in to change notification settings - Fork 41
feat: Shielding support #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Shielding support #1241
Conversation
| if (status == 0) { | ||
| out_buf.resize(used_amount); | ||
| break; | ||
| } else if (status == FASTLY_HOST_ERROR_BUFFER_LEN) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't FASTLY_HOST_ERROR_BUFFER_LEN usually set buf_size to the expected buf_size, so you don't have to keep retrying like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, yes, not in the case of this host call it seems. I'm following the Rust SDK behaviour fwiw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently it doesn't. Absolutely rude.
Adds support for shielding. Example:
There is no automated test, as there's additional complexity in ensuring that the shield POP has also gone up in time for the test to run. We could potentially add one that continually sends a request to the shield until it responds, but for now I've just tested this manually, which is also what, e.g. the Go SDK does.