Feature/migrate to dnf5 swap by bhoy-troy · Pull Request #112 · fedora-eln/content-resolver

bhoy-troy · 2026-05-14T15:03:44Z

Complete DNF5 Package Relationship Analysis

Summary

Implements full reverse dependency mapping for DNF5

Key Changes

Implemented DNF5 relationship analysis - Removed dead DNF4 code and built proper two-pass algorithm
Comprehensive documentation Started to add doc-strings to function
Code quality improvements - List comprehensions, dictionary literals, optimized filtering
Bug fixes - Fixed DnfErr typo, removed unused variables, specific exception handling
Package relationship data now populated (required_by, recommended_by, supplements)
Potential longer runtime without DNF4 caching, explainer in doc-strings

yselkowitz

Some comments below. Some of the reformatting commits are too long to review thoroughly and with multiple types of changes in the same commit; any way to break those up more granularly?

yselkowitz · 2026-05-20T17:51:36Z

+          git-core \
+          python3-yaml \
+          python3-jinja2 \
+          python3-koji \
+          python3-pytest \
+          python3-flake8 \
+          python3-libdnf5


Any reason not to alphabetize these?

No reason, the linter I used just kept the same order and placed each dependency on a new line, but I can order them

yselkowitz · 2026-05-20T17:54:03Z

+                split_line = file_line.split()
+                line_len = len(split_line)


Should this be done much earlier, and then used throughout the code, rather than just for this section?

yselkowitz · 2026-05-20T17:55:36Z


-                elif len(file_line.split()) == 8 or len(file_line.split()) == 3:
-                    pkg_name = file_line.split()[2]
+                elif line_len in (8, 3):


Probably should be (3, 8)

yselkowitz · 2026-05-20T17:55:55Z

                    required_pkgs.append(pkg_name)

-                elif len(file_line.split()) == 7 or len(file_line.split()) == 4:
+                elif line_len in (7, 4):


yselkowitz · 2026-05-20T17:56:30Z

                    continue

-                elif len(file_line.split()) == 6 or len(file_line.split()) == 5:
+                elif line_len in (6, 5):


yselkowitz · 2026-05-20T17:58:40Z

+
+        Performance Impact:
+        ------------------
+        - ~2-5 seconds added per analysis


And yet a run with the dnf5 code was much faster than with dnf4??

yselkowitz · 2026-05-20T18:05:44Z

+RUN echo "tsflags=nodocs" >> /etc/dnf/dnf.conf && \
+    echo "install_weak_deps=False" >> /etc/dnf/dnf.conf


These should be passed to the dnf command below: --setopt=tsflags=nodocs --setopt=install_weak_deps=False.

Actually, I'm going to remove this, with the caveat that it may be needed again.

There was issues in the earlier part of the migration that was causing the build to crase, but setting the flags globally seems to resolve the build issues locally.

On retesting without these flags being set it seems to build as expected.

Scrap that idea, the error isn't building of the image, it builds as expected without the flags being set.

The issue is actually using DNF5 in content resolver, thats why I has to set the flags globally in the config file.

content-resolver-dev | Resolving build group: repo-eln aarch64 content-resolver-dev | Adding packages... content-resolver-dev | Adding groups... content-resolver-dev | Resolving dependencies... content-resolver-dev | Downloading packages... content-resolver-dev | Running DNF transaction, writing RPMDB... content-resolver-dev | Error: call to ldconfig failed. content-resolver-dev | Error: call to ldconfig failed. content-resolver-dev | Creating a DNF Query object... content-resolver-dev | Done! (88 packages in total)

@yselkowitz any chance these flags being set have anything to do the warnings you mentioned that are not being hihghlighted

Not sure. What's the issue that you're trying to solve with those options?

They're pretty standard when it comes to building an image, but I definitely don't want to influence dnf5 when run by CR to skip weak deps, we specifically check for those. tsflags=nodocs doesn't affect dependencies though, so that should be safe to be global.

yselkowitz · 2026-05-20T18:06:57Z

                    goal.add_install(pkg)
-                # TODO: add custom exceptions.MarkingError
-                except Exception:
+                except  (UserAssertionError ,RepoRpmError) as e:


extra space here?

yselkowitz

Tested this with content-resolver-input (eln tag only), and I was shocked how quickly it finished (just over 2 hours from scratch, including buildroot!). I was hoping that the switch to dnf5 might speed things up somewhat, but that is huge, as it makes testing against the real configs manageable.

The package count matched perfectly, but one major difference I did notice was that there were no buildroot warnings (as in https://tiny.distro.builders/view-errors--view-eln.html in the current deployment).

Buildroot warnings arise when build dependencies of SRPMs are not resolvable. Sometimes that is indicative of a real issue (unwanted build dep), but there are a number of intentionally filtered build deps which are "known problems", e.g. rust crate packages which are used for real packages written in rust when building for Fedora but still need to be vendored for RHEL, etc. None of those filtered dependencies showed up, but neither did the expected warnings. This is a bug that needs to be fixed.

I haven't finished analyzing the results for any other differences, but the package count matching is a good start.

bhoy-troy · 2026-05-21T08:45:47Z

To reduce the noise with formatting I'll revert the changes in #514054c, we can create a seperate task to do the formatting and keep any logical changes out of it.

…s to comprehensions and f-strings

yselkowitz

Ran this on the ELN+Extras workloads. I'm seeing a bunch of warnings for virtual names which are provided by other packages, e.g. rfkill (util-linux), hardlink (util-linux-core), golang-github-cpuguy83-md2man (now go-md2man), etc. Warnings should not be produced if the virtual name is resolvable to an actual package.

bhoy-troy added 7 commits May 7, 2026 17:14

Whole bunch of updates to migrate to DNF5 and its newer syntax

8af3a8d

better exceptions and sort imports

52293dc

update Dockerfile

82394fc

use urllib to pare the URL

96d80f0

replace.format() with f-strings

112b279

better variable assignment and some formating

514054c

update version of dnf

3cae380

bhoy-troy marked this pull request as ready for review May 15, 2026 14:23

bhoy-troy marked this pull request as draft May 15, 2026 14:23

yselkowitz linked an issue May 15, 2026 that may be closed by this pull request

Port CR from python3-dnf to python3-libdnf5 #75

Open

use setdefault and comprehensions for variable assignment

b2f72db

yselkowitz reviewed May 20, 2026

View reviewed changes

yselkowitz requested changes May 21, 2026

View reviewed changes

Rollback some formatting, variable assigment changes, loop conversion…

b2f7bc8

…s to comprehensions and f-strings

bhoy-troy force-pushed the feature/migrate-to-dnf5-swap branch from 2132dc1 to b2f7bc8 Compare May 26, 2026 13:32

bhoy-troy added 4 commits June 8, 2026 09:26

allow split-line & line_len be reusable

10e8204

add compose metadata caching

07f3326

better error handling

0d35105

remove package install

02b8db6

bhoy-troy force-pushed the feature/migrate-to-dnf5-swap branch from 9d12110 to 1d56f4d Compare June 10, 2026 09:00

add dnf flags to command args, and add claude to ignore

071f35b

bhoy-troy force-pushed the feature/migrate-to-dnf5-swap branch from 1d56f4d to 071f35b Compare June 10, 2026 14:59

bhoy-troy marked this pull request as ready for review June 16, 2026 10:49

bhoy-troy requested a review from yselkowitz June 16, 2026 10:55

yselkowitz self-assigned this Jun 16, 2026

yselkowitz requested changes Jun 18, 2026

View reviewed changes

		RUN echo "tsflags=nodocs" >> /etc/dnf/dnf.conf && \
		echo "install_weak_deps=False" >> /etc/dnf/dnf.conf

Conversation

bhoy-troy commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Complete DNF5 Package Relationship Analysis

Summary

Key Changes

Uh oh!

yselkowitz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhoy-troy May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yselkowitz left a comment

Choose a reason for hiding this comment

Uh oh!

bhoy-troy commented May 21, 2026

Uh oh!

yselkowitz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bhoy-troy commented May 14, 2026 •

edited

Loading

yselkowitz left a comment •

edited

Loading

bhoy-troy May 21, 2026 •

edited

Loading