Conversation
1165f7c to
a0560cf
Compare
a0560cf to
bfc2308
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bfc2308:
|
|
Hi @erikras, can you review? Thanks 👍 |
|
Thanks for fixing the CI! 🙏 This PR addresses real issues: What this fixes: Concerns:
Questions:
Recommendation: @erikras - The CI fix is solid, but the size limit changes need review. We want to prevent bundle bloat while being realistic about current sizes. |
I was working on a fix for #1050 and may have a PR soon, but thought I would fix the CI first. It's been failing for the past 2 PRs for a few reasons: https://ci.codesandbox.io/status/final-form/react-final-form/pr/1047
iltorb(transitive dependency of bundle-size) causing the yarn install to fail. replaced bundlesize with size-limit which does the same thing and is more actively maintainedmaxSizeas the property name, notthreshold