-
Notifications
You must be signed in to change notification settings - Fork 154
chore: fix NPM publish flow #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 80.40% 80.40%
=======================================
Files 65 65
Lines 4608 4608
Branches 775 775
=======================================
Hits 3705 3705
Misses 888 888
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kriswest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Review CI failure then we can merge this |
|
Looks like this was due to a hiccup with the Docker rate limit, unrelated to the Node version change in the PR: https://github.com/finos/git-proxy/actions/runs/21365501191/job/61496029981?pr=1352 |
|
Will go ahead and merge this! |
Fixes #1334.
What was missing in #1351 is fixing the Node version as shown in the NPM guide sample snippet.
The
rc.4is successfully published on NPM - I added publish on PR for commit 4ebf646 and then removed it.