Skip to content

Conversation

@jescalada
Copy link
Contributor

@jescalada jescalada commented Jan 14, 2026

Fixes #1334.

What was missing in #1351 is fixing the Node version as shown in the NPM guide sample snippet.

The rc.4 is successfully published on NPM - I added publish on PR for commit 4ebf646 and then removed it.

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 50b43cb
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6977973d3d2901000850112c

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (dd7d162) to head (50b43cb).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files          65       65           
  Lines        4608     4608           
  Branches      775      775           
=======================================
  Hits         3705     3705           
  Misses        888      888           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada changed the title chore: attempt to fix NPM publish flow chore: fix NPM publish flow Jan 14, 2026
@jescalada jescalada requested review from a team and kriswest January 14, 2026 08:23
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest
Copy link
Contributor

Review CI failure then we can merge this

@jescalada
Copy link
Contributor Author

Looks like this was due to a hiccup with the Docker rate limit, unrelated to the Node version change in the PR:

https://github.com/finos/git-proxy/actions/runs/21365501191/job/61496029981?pr=1352

@jescalada
Copy link
Contributor Author

Will go ahead and merge this!

@jescalada jescalada merged commit e186944 into main Jan 28, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to publish to NPM on pre-release

3 participants