Skip to content

Conversation

@dcoric
Copy link
Contributor

@dcoric dcoric commented Jan 21, 2026

Summary

Removes the unused params configuration property from the fileDB (fs type) database sink configuration, as identified in #1288.

The params.filepath property was defined in the configuration schema and default config but was never actually read by the fileDB implementation. The database files are created at hardcoded paths (./.data and ./.data/db) regardless of what was configured.

Changes

  • Removed params property from the File-based DB Config schema in config.schema.json
  • Removed params block from default config in proxy.config.json
  • Updated test configuration files to remove unused params
  • Regenerated TypeScript config types
  • Updated test cases that referenced the params property

Test plan

  • All existing tests pass (539 tests)
  • Generated TypeScript types no longer include params field
  • Config validation still works correctly for fs type sinks

Closes #1288

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 25ff65a
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6970d68e1e50090008d44e7b
😎 Deploy Preview https://deploy-preview-1360.git-proxy.preview.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (09b226b) to head (25ff65a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files          65       65           
  Lines        4608     4608           
  Branches      775      775           
=======================================
  Hits         3705     3705           
  Misses        888      888           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoric dcoric self-assigned this Jan 21, 2026
@kriswest kriswest requested a review from a team January 26, 2026 13:41
@kriswest kriswest changed the title Remove unused fileDB params from config schema, defaults, and docs fix: remove unused fileDB params from config schema, defaults, and docs Jan 26, 2026
@github-actions github-actions bot added the fix label Jan 26, 2026
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest merged commit dd7d162 into finos:main Jan 26, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default config for fileDB contains unused properties

2 participants