-
Notifications
You must be signed in to change notification settings - Fork 622
fix(prompt): update role syntax in multi-msg prompt for consistency #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sahdev77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important consistency issue within the prompt definitions. It updates the role syntax in a sample multi-message prompt file, replacing an older templating style with a newer, standardized format. This ensures that all prompt definitions adhere to a uniform syntax, improving readability and maintainability for developers working with these prompts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the role syntax in go/samples/prompts/prompts/multi-msg.prompt to the <<<dotprompt:role:...>>> format for consistency. The change is correct and improves standardization. However, I've identified that TestMultiMessagesPrompt in go/ai/prompt_test.go still utilizes the old {{ role "..." }} syntax. I recommend updating this test to use the new syntax to ensure complete test coverage and maintain consistency across the codebase. It would also be valuable to verify if other samples and tests in the repository, including those for other languages, need a similar update.
|
|
||
| You are a great AI assistant that summarizes videos talking as a pirate | ||
|
|
||
| {{ role "user" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct; {{role: "user"}} is indeed the correct/expected syntax. There are bug(s) in message rendering that make it appear that {{role: "user"}} is not supported.
Description here... Help the reviewer by:
Checklist (if applicable):