Skip to content

Qt: fix receive request model handling#1838

Open
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/critical-bug-inspection-8fd6
Open

Qt: fix receive request model handling#1838
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/critical-bug-inspection-8fd6

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 8, 2026

PR intention

Fix critical receive-request dialog crashes and filtered recent-request history mis-handling in the Qt wallet.

Code changes brief

  • Pass the full WalletModel to ReceiveRequestDialog and derive the options model from it so address-type validation does not dereference an uninitialized pointer.
  • Map recent-request selections from the filter proxy to source rows before copying/deleting.
  • Remove selected source rows in descending order so filtered multi-delete cannot erase the wrong persisted requests.
Open in Web View Automation 

Co-authored-by: Reuben Yap <reuben@firo.org>
@reubenyap reubenyap marked this pull request as ready for review May 14, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant