Repository navigation
Conversation
After the first SIGINT / SIGTERM stopped exploration, the checker still walked the partial graph with GetAllNodes and the exists-witness check, which on a large graph took longer than the exploration did. A partial graph cannot refute an exists assertion, so report the stop and return before walking it. The signal handler also took one signal and returned while signal.Notify stayed registered, so every later signal was dropped and only SIGKILL ended the process. A second signal now exits with status 130. The channel is buffered, as signal.Notify requires, and a signal that lands before the processor is published now stops it once it is. Fixes fizzbee-io#384.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #384.
Model checker stoppedand returns beforeGetAllNodesand the exists check. a partial graph can't refuteexists, and deadlock / liveness were already skipped when stopped. it also no longer printsValid Nodes:or writes the communication file. simulation is unchanged.signal.Notifystayed registered, so later signals were dropped. the channel is now buffered (2).testing
tests/test_interrupt.py: interrupts a long run and checks forModel checker stoppedand noValid Nodes:. fails on main, passes here. not wired into ci.test_references.py --skip-lovable: 172 passed, 0 failed, counts unchanged.