chore: release the audit fixes as 1.1.0 - #45
Merged
Merged
Conversation
release-please proposes 2.0.0 because of the BREAKING CHANGE trailer in ad9f231, which claims verification stops accepting DSA and ElGamal keys and SHA-1 signatures after the move to ProtonMail/go-crypto. That policy is only applied by the openpgp/v2 API, and trdl uses v1: a DSA-signed tag and a SHA-1 signed tag both still pass CheckQuorums. The changes that really were breaking were reverted in #44, so the range since v1.0.0 is a minor release. Release-As: 1.1.0 Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty commit carrying a
Release-As: 1.1.0footer, so release-please retargets the release PR from 2.0.0.Needs a merge commit, not a rebase or a squash: those drop an empty commit, which is what happened to the same footer in #44.
Why 2.0.0 is wrong, and why the range is a minor release, is in #44.