fix(Continuation): Add null checks to prevent Cannot read properties of null (reading 'getCapabilities')#2209
Merged
marcelklehr merged 1 commit intodevelopfrom Mar 20, 2026
Conversation
…of null (reading 'getCapabilities') Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens sync continuation/resume logic by adding explicit runtime guards to prevent null/undefined adapter resources from causing crashes during capability negotiation and continuation restore.
Changes:
- Add precondition checks in
SyncProcess.prepareSync()to avoid callinggetCapabilities()on a null/undefined resource. - Add parameter validation in
DefaultSyncProcess.fromJSON()to fail fast when restoring a sync process with missing dependencies. - Add guards before attempting to load a pending continuation in
Accountto avoid restoring with uninitialized resources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/lib/strategies/Default.ts |
Adds runtime validation around capability negotiation and sync-process restoration from JSON. |
src/lib/Account.ts |
Adds guards before resuming a persisted continuation to avoid null-resource crashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.