Open
Conversation
kdambekalns
commented
Mar 18, 2026
Member
Author
kdambekalns
left a comment
There was a problem hiding this comment.
Some things I'd like to have your input on!
| ; Development Value: On | ||
| ; Production Value: Off | ||
| ; https://php.net/display-startup-errors | ||
| ;display_startup_errors = Off |
Member
Author
There was a problem hiding this comment.
We should set this, I think, to be in line with display_errors and the recommendation for production.
Suggested change
| ;display_startup_errors = Off | |
| display_startup_errors = Off |
| ; Development Value: 1 | ||
| ; Production Value: -1 | ||
| ; https://php.net/zend.assertions | ||
| ;zend.assertions = -1 |
Member
Author
There was a problem hiding this comment.
Suggested change
| ;zend.assertions = -1 | |
| zend.assertions = -1 |
Unless we are sure this is needed, we should probably set this to follow the recommendation for production!?
| ; The maximum number of keys (scripts) in the OPcache hash table. | ||
| ; Only numbers between 200 and 100000 are allowed. | ||
| ; Only numbers between 200 and 1000000 are allowed. | ||
| opcache.max_accelerated_files=5000 |
Member
Author
There was a problem hiding this comment.
Suggested change
| opcache.max_accelerated_files=5000 | |
| opcache.max_accelerated_files=30000 |
A Flow project easily has upwards of 25000 class files… so it seems raising this might be good?
a1ef97b to
48d928f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.