Skip to content

This PR is to add comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/efc/node_test.go.#6075

Open
LingHangwangxianjiui wants to merge 1 commit into
fluid-cloudnative:masterfrom
LingHangwangxianjiui:add-comments-testsyncscheduleinfotocachenodes
Open

This PR is to add comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/efc/node_test.go.#6075
LingHangwangxianjiui wants to merge 1 commit into
fluid-cloudnative:masterfrom
LingHangwangxianjiui:add-comments-testsyncscheduleinfotocachenodes

Conversation

@LingHangwangxianjiui

Copy link
Copy Markdown

Ⅰ. Describe what this PR does

This PR adds GoDoc comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/efc/node_test.go to improve code readability and maintainability.

Ⅱ. Does this pull request fix one issue?

fixes #1

Ⅲ. Special notes for reviews

This PR only adds comments and does not change any implementation logic.

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Hi @LingHangwangxianjiui. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a descriptive comment to the TestSyncScheduleInfoToCacheNodes function in pkg/ddc/efc/node_test.go to explain its purpose and test scenarios. There are no review comments, so no further feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

Copy link
Copy Markdown

@cheyang

cheyang commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@LingHangwangxianjiui — this PR is blocked from merging by a failing DCO check.
The DCO bot requires every commit to carry a Signed-off-by: trailer; without it the PR cannot land regardless of lgtm / approved labels or otherwise-green CI.

Please resolve this now. For a single-commit PR:

git commit --amend -s
git push --force-with-lease

For multiple commits on this branch:

git rebase --signoff origin/master
git push --force-with-lease

The code review side is finished and any merge labels already on the PR will take effect once DCO turns green. Reference: https://github.com/apps/dco

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.77%. Comparing base (bf04633) to head (644b7ff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6075   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         484      484           
  Lines       33892    33892           
=======================================
  Hits        21954    21954           
  Misses      10215    10215           
  Partials     1723     1723           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/ddc/efc/node_test.go
return engine
}

// TestSyncScheduleInfoToCacheNodes verifies that SyncScheduleInfoToCacheNodes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style nit: the blank line that used to separate the closing brace of getTestEFCEngineNode from the next declaration was removed when the doc comment was added, so the helper and the new // TestSyncScheduleInfoToCacheNodes ... block now sit visually glued together. Restoring a single blank line before the comment keeps this file aligned with the rest of the package style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create docs for dev

2 participants