Suppress IDE stack trace for setLevel failure #8639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
approved these changes
Dec 9, 2025
| // This can happen if the logger is wrapped by a 3rd party plugin that doesn't correctly implement setLevel. | ||
| // See https://github.com/flutter/flutter-intellij/issues/8631 | ||
| Logger.getInstance(PluginLogger.class).warn("Failed to set log level", e); | ||
| // Use an empty catch block to suppress the exception. |
Member
There was a problem hiding this comment.
can we warn with just the message and no exception?
Member
Author
There was a problem hiding this comment.
I haven't tried that yet. The goal here is to simply catch and log it without reporting it in the (!) on startup.
jwren
force-pushed
the
2025_3_JmixLogger_bug_2
branch
from
7685a5d to
fd4984b
Compare
pq
reviewed
Dec 9, 2025
| try { | ||
| rootLoggerInstance.setLevel(FlutterSettings.getInstance().isVerboseLogging() ? LogLevel.ALL : LogLevel.INFO); | ||
| if (isSetLevelOverridden(rootLoggerInstance)) { | ||
| rootLoggerInstance.setLevel(FlutterSettings.getInstance().isVerboseLogging() ? LogLevel.ALL : LogLevel.INFO); |
Collaborator
There was a problem hiding this comment.
Could you try this and get rid of the reflection?
try {
rootLoggerInstance.setLevel(FlutterSettings.getInstance().isVerboseLogging() ? LogLevel.ALL : LogLevel.INFO);
} catch (Throwable _) {
// Ignore
}
…lutter#8631) Suppressed IDE stack trace for setLevel failure using reflection check, and optimized with caching to avoid performance overhead.
jwren
force-pushed
the
2025_3_JmixLogger_bug_2
branch
from
fd4984b to
f4560fe
Compare
helin24
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack trace is effectively just the log message being excessively loud because of how IntelliJ handles exceptions passed to the logger.
This is a follow up on #8631