fix: require a contextual translation engine - #18
Merged
Conversation
fly1d
commented
Aug 12, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the complete diff at e4a8313. Automatic mode now requires a real contextual engine in both Web and Tauri; the offline dictionary is only reachable through explicit selection and no longer contains a sample-specific full translation. Empty and whitespace-only API keys are handled consistently, first-use setup behavior is covered in browser smoke tests, API and Rust regression tests cover the provider boundary, and the 14-day validation plan avoids collecting user content or keys. All five required GitHub checks and the full local suite pass. No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Automatic mode silently presented the small fallback dictionary as contextual translation, and the sample paragraph had a hard-coded full translation. That made first-use quality look better than arbitrary text and could invalidate customer feedback.
What changed
Validation
npm run checknpm run test:smokenpm run desktop:check