Skip to content

fix: require a contextual translation engine - #18

Merged
fly1d merged 1 commit into
mainfrom
codex/first-user-quality-gate
Aug 12, 2026
Merged

fix: require a contextual translation engine#18
fly1d merged 1 commit into
mainfrom
codex/first-user-quality-gate

Conversation

@fly1d

@fly1d fly1d commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Why

Automatic mode silently presented the small fallback dictionary as contextual translation, and the sample paragraph had a hard-coded full translation. That made first-use quality look better than arbitrary text and could invalidate customer feedback.

What changed

  • require Ollama or a configured cloud API for automatic contextual translation
  • keep the offline dictionary as an explicit word-lookup mode
  • remove the sample-specific full translation
  • add actionable first-use setup guidance on desktop and mobile
  • treat empty or whitespace-only API keys as unconfigured in Web and Tauri
  • document a 14-day first-customer validation funnel with a CNY 39 founder offer

Validation

  • npm run check
  • npm run test:smoke
  • npm run desktop:check
  • direct API checks for auto-without-engine and explicit dictionary behavior
  • manual browser review at desktop and 390 x 844 mobile viewport

@fly1d fly1d left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff at e4a8313. Automatic mode now requires a real contextual engine in both Web and Tauri; the offline dictionary is only reachable through explicit selection and no longer contains a sample-specific full translation. Empty and whitespace-only API keys are handled consistently, first-use setup behavior is covered in browser smoke tests, API and Rust regression tests cover the provider boundary, and the 14-day validation plan avoids collecting user content or keys. All five required GitHub checks and the full local suite pass. No blocking findings.

@fly1d
fly1d merged commit 6ff1aa6 into main Aug 12, 2026
5 checks passed
@fly1d
fly1d deleted the codex/first-user-quality-gate branch August 12, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant