Fix stale clipboard capture in macOS selection fallback - #22
Merged
Conversation
fly1d
commented
Aug 14, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the complete selection-capture diff at ab88aa5. The fallback now seeds the clipboard before issuing Copy, polls for a real change, restores the prior clipboard on both success and script errors, and maps an unchanged marker to an explicit no-selection error. The marker is sourced from one Rust constant, and regression tests cover marker, empty, and trimmed output. The original stale-content behavior was reproduced locally, the corrected failure state was exercised, a release app was rebuilt and launched, all local suites passed, and all five protected GitHub checks passed. No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Risk
Verification
npm run checknpm run test:smokewhen user-facing behavior changednpm run test:sitenpm run desktop:checkReview Notes
A manual probe reproduced the old behavior: with copy unavailable, the fallback returned the previous clipboard value (
✨) as selected text. After this change, the same probe returns没有检测到选中的文字. The marker is generated from one Rust constant and is never exposed to the translation layer. Clipboard restoration runs on both success and AppleScript error paths.